Skip to content

ci: switch to secret manager for sample/integration tests#375

Merged
frankyn merged 6 commits intomasterfrom
autosynth-synthtool
Jun 17, 2020
Merged

ci: switch to secret manager for sample/integration tests#375
frankyn merged 6 commits intomasterfrom
autosynth-synthtool

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented Jun 16, 2020

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/2c593734-539a-435d-8a04-27f04c90082f/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@c4f3059
Source-Link: googleapis/synthtool@6eb80fa
Source-Link: googleapis/synthtool@6d3eed6
Source-Link: googleapis/synthtool@d1addcd

@yoshi-automation
changes without context
79088b6 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation
ci(java): switch to secret manager from keystore
bb770fb 
* ci(java): switch to secret manager from keystore, use java-docs-samples user for samples tests

* fix: we don't need to supply a service account

Source-Author: Jeff Ching <chingor@google.com>
Source-Date: Mon Jun 15 11:45:21 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: d1addcdf80aa9ddef8c932c89c919024bbad7af3
Source-Link: googleapis/synthtool@d1addcd
@yoshi-automation
samples(java): fix bad character in samples.cfg from copy/paste
31d424f 
Somehow an invisible character was copy/pasted into the file and Kokoro
cannot parse the file.

Source-Author: Jeff Ching <chingor@google.com>
Source-Date: Mon Jun 15 15:42:10 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 6d3eed67a45fd58f9c7bfa173c32e4fd4fed058f
Source-Link: googleapis/synthtool@6d3eed6
@yoshi-automation
ci(java): switch integration test secrets to secret manager
ab67d48 
Source-Author: Jeff Ching <chingor@google.com>
Source-Date: Tue Jun 16 09:26:06 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 6eb80fa9f96433af8dbeb1c8323aa80cda49b374
Source-Link: googleapis/synthtool@6eb80fa
@yoshi-automation
ci(java): fix typo in java integration test secret name
45ab634 
Source-Author: BenWhitehead <BenWhitehead@users.noreply.github.com>
Source-Date: Tue Jun 16 13:32:19 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: c4f3059c27591eb24d6942a0e357ec94c80459f2
Source-Link: googleapis/synthtool@c4f3059
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2020
@chingor13 chingor13 changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. ci: switch to secret manager for sample/integration tests Jun 16, 2020
chingor13
chingor13 previously approved these changes Jun 16, 2020
View reviewed changes
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 16, 2020
@chingor13 chingor13 self-requested a review June 16, 2020 22:57
@chingor13 chingor13 removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 16, 2020
@chingor13 chingor13 dismissed their stale review June 16, 2020 22:58

made changes to this PR

@chingor13 chingor13 requested review from frankyn and removed request for chingor13 June 16, 2020 22:58
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 16, 2020 •
edited
Loading

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #375   +/-   ##
=========================================
  Coverage     63.13%   63.13%           
+ Complexity      610      601    -9     
=========================================
  Files            32       32           
  Lines          5078     5078           
  Branches        480      481    +1     
=========================================
  Hits           3206     3206           
  Misses         1708     1708           
  Partials        164      164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc39d8...651a214. Read the comment docs.

@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green bot commented Jun 17, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green bot commented Jun 17, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green bot commented Jun 17, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@frankyn frankyn merged commit b8acec7 into master Jun 17, 2020
@frankyn frankyn deleted the autosynth-synthtool branch June 17, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 left review comments

+1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. context: partial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @chingor13 @frankyn @googlebot