Skip to content

Conversation

@sydney-munro
Copy link
Contributor

@sydney-munro sydney-munro commented Mar 29, 2024

Fixes #2477

@sydney-munro sydney-munro requested review from a team as code owners March 29, 2024 20:18
@snippet-bot
Copy link

snippet-bot bot commented Mar 29, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 29, 2024
@generated-files-bot
Copy link

generated-files-bot bot commented Mar 29, 2024

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Mar 29, 2024
@sydney-munro sydney-munro force-pushed the storage-control branch 2 times, most recently from 0197e9a to d39feb2 Compare April 1, 2024 15:45
@sydney-munro sydney-munro added the owlbot:ignore instruct owl-bot to ignore a PR label Apr 1, 2024
public static void main(String... args) throws Exception {
String bucketName = args[0]; // "your-bucket-name";
StorageControlClient storageControlClient = StorageControlClient.create();
GetStorageLayoutRequest request = GetStorageLayoutRequest.newBuilder()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May help to clarify that _ represents global bucket namespace;

@sydney-munro sydney-munro requested a review from frankyn April 3, 2024 15:04

public class QuickstartStorageControlSample {
public static void main(String... args) throws Exception {
String bucketName = args[0]; // "your-bucket-name";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter will probably chime in but remove the imports for storage client as well

@sydney-munro sydney-munro merged commit 3a0b829 into main Apr 3, 2024
@sydney-munro sydney-munro deleted the storage-control branch April 3, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Storage Control Quickstart

3 participants