-
Notifications
You must be signed in to change notification settings - Fork 89
ci: sample build in Cloud Build #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
My guess as to why that error is happening: The project configuration is probably preventing buckets from being created using ACLs instead forcing Uniform Bucket Level Access. |
|
Thank you. Yes, it seems I need to turn uniform-bucket-level-access off. Memo and b/329290837 |
|
I just submitted cl/615416026. |
|
Current failure: Following the same change googleapis/java-pubsub#1943 as the value itself is not important for the meaning of the sample to customers. |
Maybe "domain:google.com" is not sufficient? |
|
The pubsub problem is resolved; |
|
Current error (link): The test: IT_SERVICE_ACCOUNT_EMAIL is set in the .cloudbuild/samples_build.yaml file in this pull request. |
|
Creating the system account for PrintFileAclForUserTest resolved the problem. Current error: => cl/615532890 |
|
Error: Another service account is needed: |
|
The service account with project ID in its name created. |
|
The key name is hardcoded: java-storage/samples/snippets/src/test/java/com/example/storage/ITObjectSnippets.java Line 100 in 45837d3
|
|
b/329758593 |
| Binding.newBuilder().setRole("roles/owner").addMembers("allAuthenticatedUsers").build(); | ||
| Binding.newBuilder() | ||
| .setRole("roles/owner") | ||
| .addMembers( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks existing Kokoro build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status restored. "Kokoro - Test: Samples — Build successful"
|
Warning: This pull request is touching the following templated files:
|
Merging from the main. |
|
Still failing at KMS test https://pantheon.corp.google.com/cloud-build/builds/43db3499-58f9-4055-be7c-bb78f9eef7ed;step=3?e=13802955&mods=logs_tg_staging&project=cloud-java-ci-sample |
|
|
Even after granting KMS admin role to service-615621127317@gs-project-accounts.iam.gserviceaccount.com (Google Storage Service Agent), it failed with the same error. |
New error |
|
@sydney-munro I think it's from https://cloud.google.com/resource-manager/docs/organization-policy/restricting-domains. In previous cases, we stopped using "allAuthenticatedUsers" or "allUsers" Would you examine whether the sample needs the principal (from customers' view point)? |
b/322966824 and go/cloud-java-sample-build-2024.