Skip to content

feat: Error Handling and Transfer Status assignment FAILED_TO_START#2028

Merged
sydney-munro merged 3 commits intofeat/transfer-managerfrom
error-handling
May 24, 2023
Merged

feat: Error Handling and Transfer Status assignment FAILED_TO_START#2028
sydney-munro merged 3 commits intofeat/transfer-managerfrom
error-handling

Conversation

@sydney-munro
Copy link
Copy Markdown
Contributor

@sydney-munro sydney-munro commented May 23, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sydney-munro sydney-munro requested a review from a team May 23, 2023 01:46
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels May 23, 2023
BenWhitehead
BenWhitehead approved these changes May 24, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit. Merge away after fix.

@sydney-munro sydney-munro added the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2023
@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green bot commented May 24, 2023

Your PR doesn't have any required checks. Please add required checks to your feat/transfer-manager branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks.

2 similar comments
@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green bot commented May 24, 2023

Your PR doesn't have any required checks. Please add required checks to your feat/transfer-manager branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks.

@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green bot commented May 24, 2023

Your PR doesn't have any required checks. Please add required checks to your feat/transfer-manager branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks.

@sydney-munro sydney-munro merged commit cbade06 into feat/transfer-manager May 24, 2023
@sydney-munro sydney-munro deleted the error-handling branch May 24, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. automerge Merge the pull request once unit tests and other checks pass. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sydney-munro @BenWhitehead