test: add more scenarios to be validated for checksum support #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BenWhitehead
commented
Oct 19, 2022
- Define 3 new content size scenarios to be validated
- data is small enough to fit within a single message of a single stream
- data requires multiple messages within a single stream
- data requires multiple messages within multiple streams
- Refactor checksum validation centric tests out of ITObjectTest into new ITObjectChecksumSupportTest
- Move ITOptionRegressionTest.Content to top level as ChecksummedTestContent and flush it out a bit more for cross usage by ITObjectChecksumSupportTest
* Define 3 new content size scenarios to be validated 1. data is small enough to fit within a single message of a single stream 2. data requires multiple messages within a single stream 3. data requires multiple messages within multiple streams * Refactor checksum validation centric tests out of ITObjectTest into new ITObjectChecksumSupportTest * Move ITOptionRegressionTest.Content to top level as ChecksummedTestContent and flush it out a bit more for cross usage by ITObjectChecksumSupportTest
frankyn
approved these changes
Oct 21, 2022
Contributor
frankyn
left a comment
There was a problem hiding this comment.
Only had 1 question; scenarios otherwise LGTM;
| // med, multiple messages single stream when resumable | ||
| ChecksummedTestContent.of(gen.genBytes(_2MiB + 3)), | ||
| // large, multiple messages and multiple streams when resumable | ||
| ChecksummedTestContent.of(gen.genBytes(_24MiB + 5))); |
Contributor
There was a problem hiding this comment.
why the 3 and 5 magic numbers being added?
Collaborator
Author
There was a problem hiding this comment.
just some number to push it past the 2MiB evenly divisible values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.