test: enable grpc config for ITBlobReadChannelTest #1689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BenWhitehead
commented
Oct 4, 2022
- fix: update GrpcBlobReadChannel to set limit as a number of bytes rather than end_offset
- fix: update StorageV2ProtoUtils#validation to treat limit as number of bytes to read rather than end_offset
- test: mark com.google.cloud.storage.it.ITBlobReadChannelTest.testReadChannelFailUpdatedGeneration as json only
- fix: update GrpcBlobReadChannel to match automatic decompression behavior of json
- fix: update GrpcBlobReadChannel to match exception behavior for failed preconditions
frankyn
approved these changes
Oct 5, 2022
…her than end_offset
…f bytes to read rather than end_offset
…ChannelFailUpdatedGeneration as json only
…d preconditions Split and renamed testReadChannelFail into the three scenarios it was testing 1. testReadChannel_preconditionFailureResultsInIOException_metagenerationMatch_specified 2. testReadChannel_preconditionFailureResultsInIOException_generationMatch_specified 3. testReadChannel_preconditionFailureResultsInIOException_generationMatch_extractor Also update BlobReadChannel to remove RetryHelper$RetryHelperException of its cause chain
b645fc5 to
1b2221a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.