feat: add GrpcStorageOptions.Builder#setAttemptDirectPath #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new builder method to all setting attempt of direct path connection. If enabled, the underlying gapic client will be configured to attempt connecting via direct path and using client side load balancing. deps: add a direct dependency to io.grpc:grpc-googleapis Rumour has it this dependency will be removed from gax, and we need to pull it up to our level to ensure it's there for storage direct path.
9d50191 to
f1aa593
Compare
frankyn
approved these changes
Oct 6, 2022
frankyn
reviewed
Oct 6, 2022
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
|
|
||
| @BetaApi | ||
| public boolean isAttemptDirectPath() { | ||
| return false; |
Contributor
There was a problem hiding this comment.
wait shouldn't this be a class property?
Collaborator
Author
There was a problem hiding this comment.
This method is under GrpcStorageDefaults. And since it's the literal value of a boolean, doesn't need a constant to create a single instance.
| */ | ||
| @BetaApi | ||
| public GrpcStorageOptions.Builder setAttemptDirectPath(boolean attemptDirectPath) { | ||
| this.attemptDirectPath = attemptDirectPath; |
Contributor
There was a problem hiding this comment.
Should this be enabled by default?
Collaborator
Author
There was a problem hiding this comment.
With the latest version of gax-java an environment variable still needs to be set in order for direct path to actually be attempted. I think this type of thing we can change the default on in the future without there being an issue as long as there isn't any overhead to the attempt.
burkedavison
reviewed
Oct 7, 2022
| endpoint = String.format("%s:%s", uri.getHost(), port > 0 ? port : 80); | ||
| break; | ||
| case "https": | ||
| endpoint = String.format("%s:%s", uri.getHost(), port > 0 ? port : 443); |
Member
There was a problem hiding this comment.
Implementer's choice, just looking at alternative syntax to avoid the implicit-fallthrough default case:
private String resolveEndpoint(String originalEndpoint) {
URI uri = URI.create(originalEndpoint);
int defaultPort = scheme.equals("http") ? 80 : 443;
int explicitPort = uri.getPort();
int port = explicitPort > 0 ? explicitPort : defaultPort;
// Gax routes the endpoint into a method which can't handle schemes.
// Unless for direct path, try and strip here if we can.
return (schema.equals("http") || schema.equals("https"))
? String.format("%s:%s", uri.getHost(), port)
: originalEndpoint;
}
@InternalApi
StorageSettings getStorageSettings() throws IOException {
String endpoint = resolveEndpoint(getHost());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new builder method to all setting attempt of direct path connection.
If enabled, the underlying gapic client will be configured to attempt connecting via direct path and using client side load balancing.
deps: add a direct dependency to io.grpc:grpc-googleapis
Rumour has it this dependency will be removed from gax, and we need to pull it up to our level to ensure it's there for storage direct path.