chore: fix native-image.properties to allow running jqwik tests #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test(deps): bump junit-platform.version to 5.9.1 Also removed a dangling bucket deletion in ITNotificationTest which was resulting in an exception at cleanup time.
frankyn
approved these changes
Oct 1, 2022
frankyn
reviewed
Oct 1, 2022
| } finally { | ||
| RemoteStorageHelper.forceDelete( | ||
| storage, bucketFixture.getBucketInfo().getName(), 5, TimeUnit.SECONDS); | ||
| // delete is taken care of by BucketFixture now |
Contributor
There was a problem hiding this comment.
Are you oging to remove the finally block?
Collaborator
Author
There was a problem hiding this comment.
Probably not, because then the code formatter will change all the indentation for the whole test and git-blame me on those lines 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(deps): bump junit-platform.version to 5.9.1
Also removed a dangling bucket deletion in ITNotificationTest which was resulting in an exception at cleanup time.