Skip to content

chore: wire automatic retries into usages of StartResumableUpload #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenWhitehead merged 1 commit into from
Sep 30, 2022
Merged

chore: wire automatic retries into usages of StartResumableUpload #1645

BenWhitehead merged 1 commit into from
Sep 30, 2022

Conversation

@BenWhitehead
Copy link
Collaborator

@BenWhitehead BenWhitehead commented Sep 22, 2022

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Sep 22, 2022
@BenWhitehead BenWhitehead force-pushed the grpc/retry/direct-upload branch from e7250ca to 1b2581a Compare September 22, 2022 16:42
@BenWhitehead BenWhitehead force-pushed the grpc/retry/start-resumable-session branch from 18396c7 to 5e572cf Compare September 22, 2022 16:48
@BenWhitehead BenWhitehead force-pushed the grpc/retry/direct-upload branch from 1b2581a to b68544c Compare September 22, 2022 19:28
@BenWhitehead BenWhitehead force-pushed the grpc/retry/start-resumable-session branch from 5e572cf to f341f1f Compare September 22, 2022 19:28
@BenWhitehead BenWhitehead force-pushed the grpc/retry/direct-upload branch from b68544c to db311d1 Compare September 23, 2022 15:53
@BenWhitehead BenWhitehead force-pushed the grpc/retry/start-resumable-session branch from f341f1f to 25bb983 Compare September 23, 2022 15:54
Base automatically changed from grpc/retry/direct-upload to feat/grpc-storage September 29, 2022 21:53
@BenWhitehead BenWhitehead force-pushed the grpc/retry/start-resumable-session branch from 25bb983 to 8fd2c6e Compare September 29, 2022 21:54
@BenWhitehead BenWhitehead marked this pull request as ready for review September 29, 2022 21:55
@BenWhitehead BenWhitehead requested a review from a team as a code owner September 29, 2022 21:55
frankyn
frankyn reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits

@BenWhitehead BenWhitehead force-pushed the grpc/retry/start-resumable-session branch from 8fd2c6e to a7eb4eb Compare September 30, 2022 16:31
@BenWhitehead BenWhitehead merged commit 0f2c73e into feat/grpc-storage Sep 30, 2022
@BenWhitehead BenWhitehead deleted the grpc/retry/start-resumable-session branch September 30, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

Storage gRPC implementation

Development

Successfully merging this pull request may close these issues.

2 participants

@BenWhitehead @frankyn