test: add property test for DefaultBufferedReadableByteChannel #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New property test against arbitrarily generated data along with buffer size, and app read size. Ensure the expected number of reads and their sizes are returned for a specific data size. Ensure channel is closed after full read, and throws a ClosedChannelException when attempted to read after close
frankyn
reviewed
Jun 14, 2022
| long bytesReadIntoBuffer = read - dstRemaining; | ||
| Buffers.position(buffer, Math.toIntExact(bytesReadIntoBuffer)); | ||
| tmpBytesCopied = Math.toIntExact(read); | ||
| flipped = false; |
Contributor
There was a problem hiding this comment.
The flipped variable is confusing for tracking purposes I mean.
| } | ||
| long copy = Buffers.copy(buffer, new ByteBuffer[] {dst}); | ||
| if (buffer.remaining() == 0) { | ||
| Buffers.clear(buffer); |
Contributor
There was a problem hiding this comment.
Shouldn't this set flipped = false?
frankyn
approved these changes
Jun 14, 2022
Contributor
|
Chatted over GVC with @BenWhitehead and cleared up the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New property test against arbitrarily generated data along with buffer size, and app read size.
Ensure the expected number of reads and their sizes are returned for a specific data size.
Ensure channel is closed after full read, and throws a ClosedChannelException when attempted to read after close