chore: add initial skeleton of Retrying for Grpc #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename RetryAlgorithmManager -> HttpRetryAlgorithmManager
* Add GrpcRetryAlgorithmManager
* Update Retrying.run(GrpcStorageOptions, ...) to take a Decoder instead
of a Function (this helps narrow things a bit to our decoders)
* Add GrpcStorageImpl#SyntaxDecoders
* For our "Syntax" types - Blob, Bucket, etc - Decoding an instance is
always of the form message -> info -> syntax. This new class gives
us a decoder that can use simply for message -> syntax by binding
to the enclosing storage instance.
* update "Syntax" return points to use new decoders
b28d5b0 to
6ee2d86
Compare
frankyn
suggested changes
Jun 3, 2022
Contributor
frankyn
left a comment
There was a problem hiding this comment.
Overall lgtm, just have one nit
| grpcStorageStub.deleteHmacKeyCallable().call(req); | ||
| return null; | ||
| }, | ||
| Decoder.identity()); |
Contributor
There was a problem hiding this comment.
Instead of identity, could we use an overload which makes Decoder optional?
Collaborator
Author
There was a problem hiding this comment.
In StorageImpl we're also using identity() for the few methods where necessary. These methods are almost exclusively delete methods (which arguably should return something better than void or boolean). So I'm not sure they are enough motivation to overload Retrying.run
frankyn
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of a Function (this helps narrow things a bit to our decoders)
always of the form message -> info -> syntax. This new class gives
us a decoder that can use simply for message -> syntax by binding
to the enclosing storage instance.