fix: fix Journaling BlobWriteSessionConfig to properly handle multiple consecutive retries#3166
Merged
BenWhitehead merged 1 commit intomainfrom Jun 25, 2025
Merged
Conversation
Collaborator
BenWhitehead
commented
Jun 24, 2025
- Clear copy buffer used to load bytes from the recovery file so, we don't have dangling bytes from a previous retry
- Do not add to the cumulative crc32c when retrying. The bytes have already been added in the first attempt.
…e consecutive retries * Clear copy buffer used to load bytes from the recovery file so, we don't have dangling bytes from a previous retry * Do not add to the cumulative crc32c when retrying. The bytes have already been added in the first attempt.
cojenco
approved these changes
Jun 25, 2025
Contributor
cojenco
left a comment
There was a problem hiding this comment.
Thanks for walking me through the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.