chore: add ready span for BlobReadSession

BenWhitehead · BenWhitehead · commit e89ae2757578 · 2025-03-18T18:18:42.000-04:00
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/OtelStorageDecorator.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/OtelStorageDecorator.java
@@ -1472,13 +1472,16 @@ public ApiFuture<BlobReadSession> blobReadSession(BlobId id, BlobSourceOption...
             .startSpan();
     try (Scope ignore1 = blobReadSessionSpan.makeCurrent()) {
       Context blobReadSessionContext = Context.current();
+      Span ready = tracer.spanBuilder("blobReadSession/ready").startSpan();
       ApiFuture<BlobReadSession> blobReadSessionApiFuture = delegate.blobReadSession(id, options);
       ApiFuture<BlobReadSession> futureDecorated =
           ApiFutures.transform(
               blobReadSessionApiFuture,
-              delegate ->
-                  new OtelDecoratingBlobReadSession(
-                      delegate, id, blobReadSessionContext, blobReadSessionSpan),
+              delegate -> {
+                ready.end();
+                return new OtelDecoratingBlobReadSession(
+                    delegate, id, blobReadSessionContext, blobReadSessionSpan);
+              },
               MoreExecutors.directExecutor());
       ApiFutures.addCallback(
           futureDecorated,
@@ -1487,6 +1490,9 @@ public ApiFuture<BlobReadSession> blobReadSession(BlobId id, BlobSourceOption...
                 blobReadSessionSpan.recordException(t);
                 blobReadSessionSpan.setStatus(StatusCode.ERROR, t.getClass().getSimpleName());
                 blobReadSessionSpan.end();
+                ready.recordException(t);
+                ready.setStatus(StatusCode.ERROR, t.getClass().getSimpleName());
+                ready.end();
               },
           MoreExecutors.directExecutor());
       return futureDecorated;
@@ -1498,6 +1504,14 @@ public ApiFuture<BlobReadSession> blobReadSession(BlobId id, BlobSourceOption...
     }
   }
 
+  @Override
+  @TransportCompatibility({Transport.GRPC})
+  @BetaApi
+  public AppendableBlobUpload appendableBlobUpload(
+      BlobInfo blob, int bufferSize, BlobWriteOption... options) throws IOException {
+    return delegate.appendableBlobUpload(blob, bufferSize, options);
+  }
+
   @Override
   public StorageOptions getOptions() {
     return delegate.getOptions();
