We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 8d4d7a3 commit c6f5b57Copy full SHA for c6f5b57
google-cloud-storage/src/main/java/com/google/cloud/storage/BlobDescriptorStream.java
@@ -259,8 +259,10 @@ public void onResponse(BidiReadObjectResponse response) {
259
int crc32C = checksummedData.getCrc32C();
260
261
try {
262
- // todo: benchmark how long it takes to compute this checksum and whether it needs to
263
- // happen on a non-io thread
+ // On a Threadripper PRO 3945WX
+ // java11+ calculating the crc32c of a 2MiB segment is ~70us
264
+ // java8 the same calculation is ~1600us
265
+ // not something to worry about offloading to another thread at this time.
266
Hasher.enabled().validateUnchecked(Crc32cValue.of(crc32C), content);
267
} catch (UncheckedChecksumMismatchException e) {
268
read.recordError(
0 commit comments