This repository was archived by the owner on Mar 26, 2026. It is now read-only.
test: add test to verify client-lib header is included#1689
Merged
Conversation
| ServerCallHandler<ReqT, RespT> next) { | ||
| String clientLibToken = | ||
| headers.get( | ||
| Metadata.Key.of("x-goog-api-client", Metadata.ASCII_STRING_MARSHALLER)); |
Contributor
There was a problem hiding this comment.
Just curious to understand where is this header value actually set?
Collaborator
Author
There was a problem hiding this comment.
It is normally automatically set by Gax, but in the Spanner client we set it manually to be able to add custom headers:
- It's defined here: https://github.com/googleapis/sdk-platform-java/blob/43de5b568dc0bbdaddf2419652e0cb16de77ddb6/java-core/google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java#L706
- It is set here: https://github.com/googleapis/java-spanner/blob/440c88bd67e1c9d08445fe26b01bf243f7fd1ca4/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java#L301
harshachinta
approved these changes
Jul 25, 2024
harshachinta
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a verification to an existing test that the standard Java client lib header is included by the JDBC driver.