This repository was archived by the owner on Mar 26, 2026. It is now read-only.
test: enable integration tests for PG on emulator#1526
Merged
gcf-merge-on-green[bot] merged 3 commits intoMar 6, 2024
Conversation
The emulator now supports PostgreSQL, so we can enable the integration tests for PostgreSQL when running on the emulator. This change also changes some of the tests that had workarounds for features that were initially missing in PostgreSQL, such as support for DATE and TIMESTAMPTZ.
ankiaga
reviewed
Mar 6, 2024
ankiaga
reviewed
Mar 6, 2024
ankiaga
reviewed
Mar 6, 2024
| public void test04_TestGetCommitTimestamp() throws Exception { | ||
| // Skipping test as Commit Timestamp not supported in POSTGRES | ||
| assumeFalse(dialect.dialect == Dialect.POSTGRESQL); | ||
| try (CloudSpannerJdbcConnection connection = createConnection(env, database)) { |
Collaborator
Author
There was a problem hiding this comment.
Yes, JDBC connections are auto-closeables, and should therefore be enclosed in try-with-resources blocks whenever possible. This ensures that the connection is closed at the end of the block, regardless what happens (e.g. exceptions, early returns, just reaching the end of the block, etc.).
Failing to close JDBC connection can cause resource leaks.
ankiaga
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emulator now supports PostgreSQL, so we can enable the integration tests for PostgreSQL when running on the emulator.
This change also changes some of the tests that had workarounds for features that were initially missing in PostgreSQL, such as support for DATE and TIMESTAMPTZ.