Skip to content

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 29, 2020

This PR contains the following updates:

Package Update Change
com.google.cloud:libraries-bom minor 5.3.0 -> 5.6.0
com.google.cloud:libraries-bom minor 5.4.0 -> 5.6.0

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2020
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label May 29, 2020
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #142 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #142      +/-   ##
============================================
+ Coverage     71.95%   72.18%   +0.22%     
- Complexity     1027     1095      +68     
============================================
  Files            24       24              
  Lines          3156     3279     +123     
  Branches        463      481      +18     
============================================
+ Hits           2271     2367      +96     
- Misses          706      718      +12     
- Partials        179      194      +15     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/spanner/jdbc/JdbcResultSet.java 79.02% <0.00%> (-2.83%) 186.00% <0.00%> (+57.00%) ⬇️
...m/google/cloud/spanner/jdbc/JdbcTypeConverter.java 73.91% <0.00%> (-0.95%) 91.00% <0.00%> (+3.00%) ⬇️
...ud/spanner/jdbc/AbstractJdbcPreparedStatement.java 90.18% <0.00%> (-0.67%) 52.00% <0.00%> (ø%)
.../com/google/cloud/spanner/jdbc/JdbcConnection.java 49.45% <0.00%> (-0.28%) 42.00% <0.00%> (ø%)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 95.23% <0.00%> (-0.01%) 180.00% <0.00%> (ø%)
...le/cloud/spanner/jdbc/JdbcSqlExceptionFactory.java 46.37% <0.00%> (+0.66%) 7.00% <0.00%> (ø%)
...google/cloud/spanner/jdbc/AbstractJdbcWrapper.java 77.31% <0.00%> (+13.31%) 51.00% <0.00%> (+8.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537fc47...33628d2. Read the comment docs.

@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@renovate-bot renovate-bot changed the title chore(deps): update dependency com.google.cloud:libraries-bom to v5.5.0 chore(deps): update dependency com.google.cloud:libraries-bom to v5.6.0 Jun 9, 2020
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud-libraries-bom-5.x branch from 0c80b31 to 70d5660 Compare June 9, 2020 13:14
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@olavloite
Copy link
Collaborator

@chingor13 Do you have any idea why the Java11 unit tests are failing with NoClassDefFound errors, while the Java8 unit tests succeed?

@forking-renovate
Copy link

forking-renovate bot commented Jun 9, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help.

@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@forking-renovate
Copy link

Autoclosing Skipped

This PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@olavloite
Copy link
Collaborator

This upgrade would cause build failures for Java 11 because of a missing dependency.

@olavloite olavloite closed this Jun 24, 2020
@renovate-bot renovate-bot deleted the renovate/com.google.cloud-libraries-bom-5.x branch June 24, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants