Skip to content

Conversation

@arawind
Copy link
Contributor

@arawind arawind commented Feb 20, 2024

No description provided.

@arawind arawind requested a review from arpan14 February 20, 2024 10:00
@arawind arawind requested review from a team as code owners February 20, 2024 10:00
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Feb 20, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Feb 20, 2024
@arawind arawind added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 22, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 22, 2024
@arpan14 arpan14 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 22, 2024
@arpan14 arpan14 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 22, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit c19f333 into googleapis:main Feb 22, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 22, 2024
@arawind arawind deleted the kokoro-cloud-devel branch February 22, 2024 10:54
@harshachinta
Copy link
Contributor

@arpan14
What is the need of adding a presubmit with cloud-devel? We never merge our PRs until the support is in Production.
We already have our presubmits flaky due to resource exhausted, and this will add up to that.

@arpan14
Copy link
Contributor

arpan14 commented Feb 22, 2024

@arpan14 What is the need of adding a presubmit with cloud-devel? We never merge our PRs until the support is in Production. We already have our presubmits flaky due to resource exhausted, and this will add up to that.

There are additional steps taken to ensure cloud-devel tests run against a different instance than production test. Additionally @arawind helped by separating the directpath tests to also run on a separate instance. All of this will reduce the current flakiness.

Also we want to run the tests again cloud-devel as a non-required step to ensure when we merge changes with disabled integration tests (for ex - proto/FLOAT32), we at-least have ensured that such tests pass against cloud-devel and fail against production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants