Skip to content

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Jan 22, 2024

@arpan14 This is is the implementation for the one I got your review in go/cloud-sdk-java-dependency-governance-design. This check will avoid accidentally adding a third-party dependency.

b/320677880

@suztomo suztomo requested review from a team as code owners January 22, 2024 15:46
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Jan 22, 2024
@suztomo
Copy link
Member Author

suztomo commented Jan 22, 2024

https://github.com/googleapis/java-spanner/actions/runs/7613727051/job/20734312537?pr=2796

Check against /home/runner/work/java-spanner/java-spanner/google-cloud-spanner-bom/pom.xml
This pull request seems to add new third-party dependency, [org.objenesis:objenesis, commons-cli:commons-cli, net.bytebuddy:byte-buddy-agent, org.mockito:mockito-core], among the artifacts listed in google-cloud-spanner-bom/pom.xml.

Marking this as draft for now. I'll wait for the troubleshooting result in b/320677260#comment3.

@suztomo suztomo marked this pull request as draft January 22, 2024 16:09
@suztomo suztomo force-pushed the unmanaged_dependency_check branch from 93c7cb1 to f82f686 Compare January 25, 2024 20:46
@suztomo suztomo force-pushed the unmanaged_dependency_check branch from f82f686 to ed77d6d Compare January 29, 2024 15:02
@suztomo
Copy link
Member Author

suztomo commented Jan 29, 2024

Now the executor module, which is not for customers, is not part of the BOM (#2844; merged). Let's see the result.

@suztomo
Copy link
Member Author

suztomo commented Jan 29, 2024

Unmanaged dependency check / unmanaged_dependency_check (pull_request) Successful

@suztomo suztomo requested a review from arpan14 January 29, 2024 15:06
@suztomo suztomo marked this pull request as ready for review January 29, 2024 15:08
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2024
@suztomo suztomo merged commit 5edd518 into main Feb 8, 2024
@suztomo suztomo deleted the unmanaged_dependency_check branch February 8, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants