test: remove partition token from tests #2738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the example partition token from the SQL test scripts, as the tokens are not stable when the encoded classes are changed. E.g. modifying the Value classes will cause these tests to fail with a de-serialization error, as the serialized version in the token no longer corresponds with the version in code. Fixes the build error in #2736
arpan14
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the example partition token from the SQL test scripts, as the tokens are not stable when the encoded classes are changed. E.g. modifying the Value classes will cause these tests to fail with a de-serialization error, as the serialized version in the token no longer corresponds with the version in code.
Fixes the build error in #2736