chore: remove double client lib token header #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the double inclusion of the standard client lib token when no custom client lib token has been set. Also reuses more of the standard feature for setting the client lib token, instaed of appending the standard token at the moment that we are creating the gRPC stub. This should reduce the probability that anyone who might be using a custom header or custom client in some way will get it wrong.
…ub.com:googleapis/java-spanner into improve-custom-client-lib-token-implementation
arpan14
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the double inclusion of the standard client lib token when no custom client lib token has been set. Also reuses more of the standard feature for setting the client lib token, instaed of appending the standard token at the moment that we are creating the gRPC stub. This should reduce the probability that anyone who might be using a custom header or custom client in some way will get it wrong.