Skip to content

test: swap expected and actual values in DML returning tests. #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpan14 merged 2 commits into from
Oct 9, 2023
Merged

test: swap expected and actual values in DML returning tests. #2663

arpan14 merged 2 commits into from
Oct 9, 2023

Conversation

@arpan14
Copy link
Contributor

@arpan14 arpan14 commented Oct 9, 2023

While debugging flaky issue - #2629 , it was noticed that ITDmlReturningTest is not using the right convention for assertEquals method. This PR swaps the value so that debugging readability is improved.

For ex - The following error message in the above issue is confusing due to this swap between expected/actual values.

java.lang.AssertionError: expected:<1> but was:<2>

@arpan14 arpan14 requested a review from a team as a code owner October 9, 2023 08:40
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Oct 9, 2023
@arpan14 arpan14 requested a review from harshachinta October 9, 2023 08:57
harshachinta
harshachinta approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpan14 arpan14 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 9, 2023
@arpan14 arpan14 merged commit b475c0f into googleapis:main Oct 9, 2023
@arpan14 arpan14 deleted the flaky-test-fix branch October 9, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshachinta harshachinta harshachinta approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpan14 @harshachinta