ci: javadoc job (JDK 17) in ci.yaml (#1819) #2515

gcf-owl-bot · 2023-06-27T18:56:44Z

This also changes the JDK distribution from zulu to temurin
https://github.com/actions/setup-java#eclipse-temurin
Source-Link: googleapis/synthtool@ef9fe2e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9

This also changes the JDK distribution from zulu to temurin https://github.com/actions/setup-java#eclipse-temurin Source-Link: googleapis/synthtool@ef9fe2e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9

suztomo · 2023-06-28T20:40:16Z

Errors: https://github.com/googleapis/java-spanner/actions/runs/5394815252/jobs/9796509445?pr=2515

Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java:108: error: reference not found
Error:     *         <li>{@link ResultSet#tryNext()} returns {@link CursorState#DONE}.
Error:                          ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java:109: error: reference not found
Error:     *         <li>{@link ResultSet#tryNext()} throws an exception.
Error:                          ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java:111: error: reference not found
Error:     *   <li>Callback may possibly be invoked after a call to {@link ResultSet#cancel()} call, but the
Error:                                                                     ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java:118: error: unexpected heading used: <H3>, compared to implicit preceding heading: <H3>
Error:     * <h3>Flow Control</h3>
Error:       ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java:63: error: reference not found
Error:       * Tell the cursor to suspend all callbacks until application calls {@link RowCursor#resume()}.
Error:                                                                                 ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java:71: error: reference not found
Error:       * <p>Approximately equivalent to calling {@link RowCursor#cancel()}, and then returning {@code
Error:                                                       ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncRunner.java:43: error: reference not found
Error:       * should never catch an exception of type {@link SpannerErrors#isAborted}: these indicate that
Error:                                                        ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncTransactionManager.java:163: error: reference not found
Error:     * #resetForRetry()}.
Error:       ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncTransactionManager.java:154: error: unexpected text
Error:       *     Instead, if the method does not have a return value, the method should return {@link
Error:                                                                                           ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java:159: error: bad HTML entity
Error:     * If this is for a partitioned read & query and this field is set to `true`, the request will be
Error:                                         ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java:140: error: reference not found
Error:     * @see also #createDatabase(String, String, Iterable)
Error:            ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java:371: error: reference not found
Error:     * is meant for advanced users. Most users should instead use the {@link #readWriteTransaction()}
Error:                                                                             ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java:419: error: unknown tag: Long
Error:     * ApiFuture<Long> rowCount =
Error:                ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java:452: error: reference not found
Error:     * #runAsync()} API instead.
Error:       ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java:517: error: reference not found
Error:     * table-wide operations than DML in a {@link #readWriteTransaction()} transaction. Smaller scoped
Error:                                                  ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java:519: error: reference not found
Error:     * TransactionContext#executeUpdate(Statement)} with {@link #readWriteTransaction()}.
Error:       ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java:519: error: reference not found
Error:     * TransactionContext#executeUpdate(Statement)} with {@link #readWriteTransaction()}.
Error:                                                                ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java:522: error: reference not found
Error:     * #readWriteTransaction()}.
Error:       ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceConfigInfo.java:120: error: unknown tag: project_name
Error:     * Base configuration, e.g. projects/<project_name>/instanceConfigs/nam3, based on which this
Error:                                         ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Session.java:51: error: reference not found
Error:     * Prepares a transaction for use by a subsequent {@link #readWriteTransaction()} or {@link
Error:                                                             ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java:973: error: reference not found
Error:       * DatabaseClient#executePartitionedUpdate(Statement)}. The default is 2 hours.
Error:         ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java:1069: error: reference not found
Error:       * preference above any {@link Credentials} that may have been set on the {@link SpannerOptions}
Error:                                     ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionContext.java:121: error: reference not found
Error:     * Same as {@link #executeUpdate(Statement)}, but is guaranteed to be non-blocking. If multiple
Error:                      ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionContext.java:182: error: reference not found
Error:     * Same as {@link #batchUpdate(Iterable)}, but is guaranteed to be non-blocking. If multiple
Error:                      ^

@arpan14 Would you fix the invalid Javadoc in this library? It's not urgent. If it's too much, I can take care of them.

The warnings are just warnings. Focus on fixing "errors: ".

suztomo · 2023-07-20T16:05:38Z

It still shows errors.

Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java:159: error: bad HTML entity
Error:     * If this is for a partitioned read & query and this field is set to `true`, the request will be
Error:                                         ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseAdminClient.java:140: error: reference not found
Error:     * @see also #createDatabase(String, String, Iterable)
Error:            ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java:419: error: unknown tag: Long
Error:     * ApiFuture<Long> rowCount =
Error:                ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceConfigInfo.java:120: error: unknown tag: project_name
Error:     * Base configuration, e.g. projects/<project_name>/instanceConfigs/nam3, based on which this
Error:                                         ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Session.java:51: error: reference not found
Error:     * Prepares a transaction for use by a subsequent {@link #readWriteTransaction()} or {@link
Error:                                                             ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java:973: error: reference not found
Error:       * DatabaseClient#executePartitionedUpdate(Statement)}. The default is 2 hours.
Error:         ^
Error:  /home/runner/work/java-spanner/java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java:1069: error: reference not found
Error:       * preference above any {@link Credentials} that may have been set on the {@link SpannerOptions}

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

gcf-owl-bot bot requested review from a team as code owners June 27, 2023 18:56

gcf-owl-bot bot added the owl-bot-update-lock label Jun 27, 2023

product-auto-label bot added the size: s Pull request size is small. label Jun 27, 2023

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 27, 2023

product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jun 27, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2023

yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 27, 2023

temurin

ed05dea

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 27, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2023

arpan14 mentioned this pull request Jul 20, 2023

docs: fixing errors #2536

Merged

product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Jul 20, 2023

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 20, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2023

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 20, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2023

suztomo approved these changes Jul 20, 2023

View reviewed changes

suztomo force-pushed the owl-bot-update-lock-31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9 branch from 464393f to ed05dea Compare July 20, 2023 17:36

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 20, 2023

product-auto-label bot added size: s Pull request size is small. and removed size: l Pull request size is large. labels Jul 20, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2023

🦉 Updates from OwlBot post-processor

6e04332

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2023

product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 20, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2023

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2023

arpan14 approved these changes Jul 21, 2023

View reviewed changes

arpan14 merged commit b14ee87 into main Jul 21, 2023

arpan14 deleted the owl-bot-update-lock-31c8276a1bfb43766597d32645721c029cb94571f1b8d996cb2c290744fe52f9 branch July 21, 2023 04:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: javadoc job (JDK 17) in ci.yaml (#1819) #2515

ci: javadoc job (JDK 17) in ci.yaml (#1819) #2515

Uh oh!

gcf-owl-bot bot commented Jun 27, 2023

Uh oh!

suztomo commented Jun 28, 2023 •

edited

Loading

Uh oh!

suztomo commented Jul 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ci: javadoc job (JDK 17) in ci.yaml (#1819) #2515

ci: javadoc job (JDK 17) in ci.yaml (#1819) #2515

Uh oh!

Conversation

gcf-owl-bot bot commented Jun 27, 2023

Uh oh!

suztomo commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suztomo commented Jul 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

suztomo commented Jun 28, 2023 •

edited

Loading