Skip to content

Conversation

@olavloite
Copy link
Collaborator

Reverts #2363

@rajatbhatta It seems that we need to revert this, as the integration tests have started failing after this update with an error related to this version bump.

@olavloite olavloite requested a review from rajatbhatta April 7, 2023 10:17
@olavloite olavloite requested review from a team as code owners April 7, 2023 10:17
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Apr 7, 2023
@rajatbhatta
Copy link
Contributor

rajatbhatta commented Apr 7, 2023

@olavloite: thanks but it’s weird that all github checks passed before we merged that version upgrade PR. We should analyze (maybe after this is fixed) why that PR merge wasn’t blocked.

@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2023
@rajatbhatta rajatbhatta merged commit 36eb38f into main Apr 7, 2023
@rajatbhatta rajatbhatta deleted the revert-2363-renovate/org.jacoco-jacoco-maven-plugin-0.x branch April 7, 2023 17:08
@olavloite
Copy link
Collaborator Author

@olavloite: thanks but it’s weird that all github checks passed before we merged that version upgrade PR. We should analyze (maybe after this is fixed) why that PR merge wasn’t blocked.

Yes, I noticed that too, and that is weird. As far as I can see, the PR did run all tests, including the integration tests that started failing after it was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants