Skip to content

test: Configuring ITDatabaseRolePermissionTest to use SpannerOptions … #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rajatbhatta merged 3 commits into from
Feb 24, 2023
Merged

test: Configuring ITDatabaseRolePermissionTest to use SpannerOptions … #2304

rajatbhatta merged 3 commits into from
Feb 24, 2023

Conversation

@gauravpurohit06
Copy link
Contributor

@gauravpurohit06 gauravpurohit06 commented Feb 24, 2023

Using SpannerOptions from helper class while creating a new SpannerOptions to override specific properties.

@gauravpurohit06 gauravpurohit06 requested a review from a team as a code owner February 24, 2023 14:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Feb 24, 2023
@gauravpurohit06 gauravpurohit06 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 24, 2023 15:02
rajatbhatta
rajatbhatta approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@rajatbhatta rajatbhatta merged commit 576d8b9 into googleapis:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gauravpurohit06 @rajatbhatta