Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

deps: regenerating with new Protobuf (6.4.4-sp)#2135

Merged
suztomo merged 4 commits into6.4.4-spfrom
6.4.4-sp_patch
Nov 2, 2022
Merged

deps: regenerating with new Protobuf (6.4.4-sp)#2135
suztomo merged 4 commits into6.4.4-spfrom
6.4.4-sp_patch

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Nov 2, 2022 •
edited
Loading

To merge into 6.4.4-sp branch. This PR was generated using Protobuf 3.16.3. Source-Link: googleapis/googleapis@3b236df

GraalVM tests are expected to fail because we didn't have GraalVM configuration file when 6.4.4 was released.

"ci / dependencies" are also expected to fail because the gRPC version 1.36 is not the latest version among dependency tree (1.37.0 is). As long as the library works with 1.36.3, it's fine.

@suztomo suztomo requested review from a team November 2, 2022 03:11
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/java-spanner API. labels Nov 2, 2022
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot bot commented Nov 2, 2022 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Backup.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/BackupInfo.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupEncryptionConfig.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupMetadata.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateBackupRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseMetadata.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/CreateDatabaseRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/Database.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/DeleteBackupRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/DropDatabaseRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/EncryptionConfig.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/EncryptionInfo.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/GetBackupRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/GetDatabaseDdlRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/GetDatabaseDdlResponse.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/GetDatabaseRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/ListBackupOperationsRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/ListBackupOperationsResponse.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/ListBackupsRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/ListBackupsResponse.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/ListDatabaseOperationsRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/ListDatabaseOperationsResponse.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/ListDatabasesRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/ListDatabasesResponse.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/OperationProgress.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/OptimizeRestoredDatabaseMetadata.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseEncryptionConfig.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseMetadata.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreDatabaseRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/RestoreInfo.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/UpdateBackupRequest.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/UpdateDatabaseDdlMetadata.java
  • proto-google-cloud-spanner-admin-database-v1/src/main/java/com/google/spanner/admin/database/v1/UpdateDatabaseDdlRequest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/CreateInstanceMetadata.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/CreateInstanceRequest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/DeleteInstanceRequest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/GetInstanceConfigRequest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/GetInstanceRequest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/Instance.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/InstanceConfig.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/ListInstanceConfigsRequest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/ListInstanceConfigsResponse.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/ListInstancesRequest.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/ListInstancesResponse.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/ReplicaInfo.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/UpdateInstanceMetadata.java
  • proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/UpdateInstanceRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/BatchCreateSessionsRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/BatchCreateSessionsResponse.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/BeginTransactionRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/CommitRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/CommitResponse.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/CreateSessionRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/DeleteSessionRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ExecuteBatchDmlRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ExecuteBatchDmlResponse.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ExecuteSqlRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/GetSessionRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/KeyRange.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/KeySet.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ListSessionsRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ListSessionsResponse.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/Mutation.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/PartialResultSet.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/Partition.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/PartitionOptions.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/PartitionQueryRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/PartitionReadRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/PartitionResponse.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/PlanNode.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/QueryPlan.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ReadRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/RequestOptions.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ResultSet.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ResultSetMetadata.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/ResultSetStats.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/RollbackRequest.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/Session.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/StructType.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/Transaction.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/TransactionOptions.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/TransactionSelector.java
  • proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/Type.java

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 2, 2022 

Warning:  Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for io.grpc:grpc-api:1.36.3 paths to dependency are:
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.grpc:grpc-api:1.36.3
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.grpc:grpc-auth:1.36.3
    +-io.grpc:grpc-api:1.36.3
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.grpc:grpc-core:1.36.3
    +-io.grpc:grpc-api:1.36.3
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.grpc:grpc-protobuf:1.36.3
    +-io.grpc:grpc-api:1.36.3
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.grpc:grpc-stub:1.36.3
    +-io.grpc:grpc-api:1.36.3
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-com.google.api.grpc:grpc-google-common-protos:2.1.0
    +-io.grpc:grpc-api:1.36.3 (managed) <-- io.grpc:grpc-api:1.36.0
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-com.google.cloud:google-cloud-core-grpc:1.94.8
    +-io.grpc:grpc-api:1.36.3 (managed) <-- io.grpc:grpc-api:1.37.0
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-com.google.api.grpc:grpc-google-cloud-spanner-admin-instance-v1:6.4.4-sp.7-SNAPSHOT
    +-io.grpc:grpc-api:1.36.3 (managed) <-- io.grpc:grpc-api:1.37.0
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-com.google.api.grpc:grpc-google-cloud-spanner-v1:6.4.4-sp.7-SNAPSHOT
    +-io.grpc:grpc-api:1.36.3 (managed) <-- io.grpc:grpc-api:1.37.0
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-com.google.api.grpc:grpc-google-cloud-spanner-admin-database-v1:6.4.4-sp.7-SNAPSHOT
    +-io.grpc:grpc-api:1.36.3 (managed) <-- io.grpc:grpc-api:1.37.0
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.grpc:grpc-protobuf:1.36.3
    +-io.grpc:grpc-protobuf-lite:1.36.3
      +-io.grpc:grpc-api:1.36.3
, 
Require upper bound dependencies error for io.grpc:grpc-core:1.36.3 paths to dependency are:
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.grpc:grpc-core:1.36.3
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.grpc:grpc-netty-shaded:1.36.3
    +-io.grpc:grpc-core:1.36.3
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-com.google.cloud:google-cloud-core-grpc:1.94.8
    +-io.grpc:grpc-core:1.36.3 (managed) <-- io.grpc:grpc-core:1.37.0
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.opencensus:opencensus-contrib-grpc-util:0.30.0
    +-io.grpc:grpc-core:1.36.3 (managed) <-- io.grpc:grpc-core:1.27.2
and
+-com.google.cloud:google-cloud-spanner:6.4.4-sp.7-SNAPSHOT
  +-io.grpc:grpc-alts:1.36.3
    +-io.grpc:grpc-grpclb:1.36.3
      +-io.grpc:grpc-core:1.36.3
]

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 2, 2022

Kokoro - Test: Integration — Build failed:

com.google.cloud.spanner.InstanceNotFoundException:
NOT_FOUND: com.google.cloud.spanner.InstanceNotFoundException: NOT_FOUND: io.grpc.StatusRuntimeException: NOT_FOUND: Instance not found: projects/gcloud-devel/instances/spanner-testing-west1
resource_type: "type.googleapis.com/google.spanner.admin.instance.v1.Instance"
resource_name: "projects/gcloud-devel/instances/spanner-testing-west1"
description: "Instance does not exist."

	at com.google.cloud.spanner.SpannerExceptionFactory.newSpannerExceptionPreformatted(SpannerExceptionFactory.java:279)
	at com.google.cloud.spanner.SpannerExceptionFactory.newSpannerException(SpannerExceptionFactory.java:61)
	at com.google.cloud.spanner.SpannerExceptionFactory.newSpannerException(SpannerExceptionFactory.java:181)
	at com.google.cloud.spanner.SpannerExceptionFactory.newSpannerException(SpannerExceptionFactory.java:110)
	at com.google.cloud.spanner.testing.RemoteSpannerHelper.createTestDatabase(RemoteSpannerHelper.java:130)
	at com.google.cloud.spanner.testing.RemoteSpannerHelper.createTestDatabase(RemoteSpannerHelper.java:96)
	at com.google.cloud.spanner.connection.ITAbstractSpannerTest.setup(ITAbstractSpannerTest.java:222)

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 2, 2022

Cherry-picked 7b0443f

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 2, 2022

GraalVM tests are expected to fail because we didn't have GraalVM configuration file when 6.4.4 was released.

"ci / dependencies" are also expected to fail because the gRPC version 1.36 is not the latest version among dependency tree (1.37.0 is). As long as the library works with 1.36.3, it's fine.

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 2, 2022 

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] error reading /root/.m2/repository/com/google/api/grpc/proto-google-common-protos/2.1.0/proto-google-common-protos-2.1.0.jar; zip file is empty
[ERROR] error reading /root/.m2/repository/com/google/api/grpc/proto-google-common-protos/2.1.0/proto-google-common-protos-2.1.0.jar; zip file is empty
[ERROR] /tmpfs/src/github/java-spanner/proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/SpannerInstanceAdminProto.java:[238,29] cannot find symbol
  symbol:   class AnnotationsProto
  location: package com.google.api
[ERROR] /tmpfs/src/github/java-spanner/proto-google-cloud-spanner-admin-instance-v1/src/main/java/com/google/spanner/admin/instance/v1/SpannerInstanceAdminProto.java:[239,29] cannot find symbol
  symbol:   class ClientProto
  location: package com.google.api

Artifact download error. Retrying.

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 2, 2022

Integration test succeeded.

Screen Shot 2022-11-02 at 10 11 57 AM

rajatbhatta
rajatbhatta approved these changes Nov 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@suztomo suztomo merged commit ebeac9a into 6.4.4-sp Nov 2, 2022
@suztomo suztomo deleted the 6.4.4-sp_patch branch November 2, 2022 15:14
@release-please release-please bot mentioned this pull request Nov 2, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suztomo @rajatbhatta