Skip to content

test: Reducing nesting to 80 from 90 for valid JSON test #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gauravpurohit06 merged 1 commit into from
Sep 28, 2022
Merged

test: Reducing nesting to 80 from 90 for valid JSON test #2051

gauravpurohit06 merged 1 commit into from
Sep 28, 2022

Conversation

@gauravpurohit06
Copy link
Contributor

@gauravpurohit06 gauravpurohit06 commented Sep 27, 2022 •
edited
Loading

Fixes #2038

@gauravpurohit06 gauravpurohit06 requested review from a team as code owners September 27, 2022 17:28
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Sep 27, 2022
rajatbhatta
rajatbhatta approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 28, 2022
@gauravpurohit06 gauravpurohit06 merged commit 10dbf31 into googleapis:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

spanner.it.ITJsonWriteReadTest: testWriteValidJsonValues failed

2 participants

@gauravpurohit06 @rajatbhatta