Skip to content

test: Creating dummy spanner instance for ITInstanceAdminTest #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gauravpurohit06 merged 7 commits into from
Aug 22, 2022
Merged

test: Creating dummy spanner instance for ITInstanceAdminTest #1977

gauravpurohit06 merged 7 commits into from
Aug 22, 2022

Conversation

@gauravpurohit06
Copy link
Contributor

@gauravpurohit06 gauravpurohit06 commented Aug 17, 2022

Fixes #1626

@gauravpurohit06 gauravpurohit06 requested a review from a team as a code owner August 17, 2022 12:15
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Aug 17, 2022
@gauravpurohit06 gauravpurohit06 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 17, 2022
@gauravpurohit06 gauravpurohit06 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 17, 2022
@gauravpurohit06 gauravpurohit06 changed the title test: Creating dummy spanner instance for ITInstanceAdminTest [Do not merge] test: Creating dummy spanner instance for ITInstanceAdminTest Aug 17, 2022
rajatbhatta
rajatbhatta suggested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, except a comment. PTAL.

@rajatbhatta rajatbhatta requested a review from olavloite August 18, 2022 12:07
olavloite
olavloite reviewed Aug 18, 2022
View reviewed changes
olavloite
olavloite approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a suggestion regarding the naming of the createNewInstance / alwaysCreateNewInstance property.

rajatbhatta
rajatbhatta approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@gauravpurohit06 gauravpurohit06 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@gauravpurohit06 gauravpurohit06 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 22, 2022
@gauravpurohit06 gauravpurohit06 merged commit 7f5bac6 into googleapis:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olavloite olavloite olavloite approved these changes

+1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ITInstanceAdminTest #update / #updateViaEntity fail when two tests are running simultaneously

3 participants

@gauravpurohit06 @olavloite @rajatbhatta