test: add Spanner JSON test suite #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner-json # Conflicts: # google-cloud-spanner/src/test/java/com/google/cloud/spanner/AbstractStructReaderTypesTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java
…ner-json # Conflicts: # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java
…nto spanner-json-test-suit
…ner into spanner-json-test-suit # Conflicts: # google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITJsonWriteReadTest.java # google-cloud-spanner/src/test/resources/com/google/cloud/spanner/it/valid/y_100_nested.json
…nto spanner-json-test-suit # Conflicts: # google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java # google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueBinderTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java # proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/TypeCode.java # proto-google-cloud-spanner-v1/src/main/proto/google/spanner/v1/type.proto
olavloite
reviewed
Aug 24, 2021
| databaseClient.singleUse().executeQuery(Statement.of("SELECT * FROM " + TABLE_NAME)); | ||
| int count = 0; | ||
| while (resultSet.next()) { | ||
| count++; |
Collaborator
There was a problem hiding this comment.
I think we should either (in order of preference):
- Do a
resultSet.getJson("json")here to verify that the value is also gettable in the client. - Or: Just re-write the query to a
SELECT COUNT(*) ...
Contributor
Author
There was a problem hiding this comment.
I ended up going with option 2, because the JSON that gets returned is often not the same as what's inserted (e.g. [123e45] gets returned as [1.23e+47]), and it's difficult to automatically determine whether the returned value is equivalent to the inserted value without the same library that the backend uses to parse JSON. Since the tests are only there to confirm that the backend is able to accept the valid values, I don't think I'll bother spending the extra time manually adding the expected results for each file. Hopefully this is okay!
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITJsonWriteReadTest.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITJsonWriteReadTest.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITJsonWriteReadTest.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java
Outdated
Show resolved
Hide resolved
…nto spanner-json-test-suit
olavloite
approved these changes
Aug 31, 2021
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITJsonWriteReadTest.java
Outdated
Show resolved
Hide resolved
| .singleUse() | ||
| .executeQuery(Statement.of("SELECT COUNT(*) FROM " + TABLE_NAME))) { | ||
| resultSet.next(); | ||
| assertEquals(resultSet.getLong(0), resources.size()); |
Contributor
There was a problem hiding this comment.
Should we validate the JSON string as well?
Contributor
Author
There was a problem hiding this comment.
We had a discussion about this above: #1376 (comment)
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITJsonWriteReadTest.java
Outdated
Show resolved
Hide resolved
thiagotnunes
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️