Skip to content

chore: add samples for JSON #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 18 commits into from
Aug 30, 2021
Merged

chore: add samples for JSON #1375

gcf-merge-on-green merged 18 commits into from
Aug 30, 2021

Conversation

@zoercai
Copy link
Contributor

@zoercai zoercai commented Aug 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

zoercai added 6 commits July 1, 2021 19:45
@zoercai
feat: add JSON type support, with integration tests
f6aaa5f
@zoercai
chore: add samples for JSON
42ca631
@zoercai
formatting
18b68d8
@zoercai
formatting
ba27df3
@zoercai
change revenueDetails to venueDetails
7fb90a4
@zoercai
Merge branch 'master' of https://github.com/googleapis/java-spanner i…
114c974 
…nto json-sample

# Conflicts:
#	google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java
#	google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java
#	google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java
#	google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueBinderTest.java
#	samples/snippets/src/main/java/com/example/spanner/SpannerSample.java
#	samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java
@zoercai zoercai requested a review from a team as a code owner August 24, 2021 03:34
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Aug 24, 2021
@snippet-bot
Copy link

snippet-bot bot commented Aug 24, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
@zoercai zoercai mentioned this pull request Aug 24, 2021
Closed
4 tasks
@zoercai zoercai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
olavloite
olavloite reviewed Aug 24, 2021
View reviewed changes
@zoercai zoercai requested a review from olavloite August 25, 2021 10:32
olavloite
olavloite reviewed Aug 25, 2021
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The samples look good to me, but I noticed that there are now no integration tests at all for these samples. Is that intentional? Normally we add tests for such standalone samples like this: https://github.com/googleapis/java-spanner/blob/master/samples/snippets/src/test/java/com/example/spanner/GetCommitStatsSampleIT.java

@zoercai
Copy link
Contributor Author

zoercai commented Aug 26, 2021

The samples look good to me, but I noticed that there are now no integration tests at all for these samples. Is that intentional? Normally we add tests for such standalone samples like this: https://github.com/googleapis/java-spanner/blob/master/samples/snippets/src/test/java/com/example/spanner/GetCommitStatsSampleIT.java

I added some tests to SpannerStandaloneExamplesIT.java which already contains similar tests for numeric. Happy to move them into a separate test class, let me know if you'd prefer that.

@zoercai zoercai requested a review from olavloite August 26, 2021 03:28
olavloite
olavloite approved these changes Aug 26, 2021
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoercai zoercai added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0d8aa7d into googleapis:master Aug 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2021
@zoercai zoercai deleted the json-sample branch August 30, 2021 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olavloite olavloite olavloite approved these changes

@thiagotnunes thiagotnunes Awaiting requested review from thiagotnunes

Assignees

@stephaniewang526 stephaniewang526

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zoercai @olavloite @stephaniewang526 @yoshi-kokoro