This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: add keepalives to GRPC channel#11
Merged
olavloite merged 2 commits intogoogleapis:masterfrom Jan 14, 2020
allenpradeep:add_keepalive_time
Merged
fix: add keepalives to GRPC channel#11olavloite merged 2 commits intogoogleapis:masterfrom allenpradeep:add_keepalive_time
olavloite merged 2 commits intogoogleapis:masterfrom
allenpradeep:add_keepalive_time
Conversation
mbril
approved these changes
Jan 6, 2020
chore: update common templates (#12)
This patch adds keepalives to the GRPC channel every 2 minutes. By default, there are no keepalives to the GRPC channel. While running dataflow import jobs, issues have been observed with the spanner commit calls that run more than 10 minutes. Adding keepalives to the GRPC channel solves these issues.
Contributor
Author
|
@skuruppu - Can you please take a look at this. |
skuruppu
approved these changes
Jan 10, 2020
Contributor
Author
|
Hi @skuruppu, |
Contributor
Author
|
Thanks @olavloite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds keepalives to the GRPC channel every 2 minutes. By default, there are no keepalives to the GRPC channel. While running dataflow import jobs, issues have been observed with the spanner commit calls that run more than 10 minutes. Adding keepalives to the GRPC channel solves these issues.