Skip to content

Conversation

@olavloite
Copy link
Collaborator

The comparison included the progress of the operation. If the operation is fetched twice, there is a (small) chance that the reported progress between the two will differ, but that should not cause the test to fail. This PR removes the progress field from the comparison.

Fixes #1033

@olavloite olavloite requested a review from thiagotnunes April 23, 2021 10:09
@olavloite olavloite requested a review from a team as a code owner April 23, 2021 10:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #1091 (cc4d148) into master (71d7fd1) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1091      +/-   ##
============================================
- Coverage     85.15%   85.12%   -0.03%     
+ Complexity     2720     2718       -2     
============================================
  Files           155      155              
  Lines         14351    14351              
  Branches       1358     1358              
============================================
- Hits          12221    12217       -4     
- Misses         1562     1564       +2     
- Partials        568      570       +2     
Impacted Files Coverage Δ Complexity Δ
...ud/spanner/SessionPoolAsyncTransactionManager.java 85.03% <0.00%> (-1.58%) 13.00% <0.00%> (-2.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java 88.82% <0.00%> (-0.40%) 74.00% <0.00%> (-1.00%)
...m/google/cloud/spanner/connection/SpannerPool.java 87.70% <0.00%> (+0.53%) 33.00% <0.00%> (ø%)
.../google/cloud/spanner/AbstractLazyInitializer.java 100.00% <0.00%> (+7.14%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d7fd1...cc4d148. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 82ec548 into master Apr 25, 2021
@thiagotnunes thiagotnunes deleted the issue-1033 branch April 25, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spanner.it.ITDatabaseAdminTest: updateDdlRetry failed

2 participants