Skip to content

com.google.cloud.spanner.it.ITQueryOptionsTest.executeUpdate Fails for 100000 #249

@sid-dinesh94

Description

@sid-dinesh94

Looking at:

QueryOptions.newBuilder().setOptimizerVersion("10000").build())

I see that the test was intended for Version 100,000. But Version 10,000 was provided to the run command.

The comment does say that for version 100,000 the backend should safely ignore it. At least for version 10,000 the backend does not ignore and in fact throws an error:

com.google.cloud.spanner.SpannerException: INVALID_ARGUMENT: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Query optimizer version: 10000 is not supported
	at com.google.cloud.spanner.it.ITQueryOptionsTest.executeUpdate(ITQueryOptionsTest.java:157)
Caused by: java.util.concurrent.ExecutionException: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Query optimizer version: 10000 is not supported
	at com.google.cloud.spanner.it.ITQueryOptionsTest.executeUpdate(ITQueryOptionsTest.java:157)
Caused by: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Query optimizer version: 10000 is not supported
Caused by: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Query optimizer version: 10000 is not supported

A fix might be to add a zero to Line 168; but i do not have full context of this test.

Metadata

Metadata

Assignees

Labels

api: spannerIssues related to the googleapis/java-spanner API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions