feat: allows for getting json columns using getValue #1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for getting JSON values using resultSet.getValue().
Overrides the getString method in json values to allow for getString and getStringArray on json values.
olavloite
approved these changes
Feb 18, 2022
|
|
||
| private void assertThrowsWithMessage(Supplier<?> supplier, String message) { | ||
| try { | ||
| supplier.get(); |
Collaborator
There was a problem hiding this comment.
nit: I think you could also just use assertThrows(...) for this instead of a try-catch-block.
Contributor
Author
There was a problem hiding this comment.
I don't think we can, because we match partially on the message of the exception
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITResultSetGetValue.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITResultSetGetValue.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
thiagotnunes
commented
Feb 21, 2022
|
|
||
| ```Groovy | ||
| implementation 'com.google.cloud:google-cloud-spanner:6.19.0' | ||
| implementation 'com.google.cloud:google-cloud-spanner:6.19.1' |
Contributor
Author
There was a problem hiding this comment.
(This is a change from owlbot)
|
|
||
| ```Scala | ||
| libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.19.0" | ||
| libraryDependencies += "com.google.cloud" % "google-cloud-spanner" % "6.19.1" |
Contributor
Author
There was a problem hiding this comment.
(This is a change from owlbot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for getting JSON values using resultSet.getValue(). This was not possible before, because a mapping was missing.
Overrides the getString method in json values to allow for getString and getStringArray on json values.