fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests. (#2268)

Arpan Mishra · web-flow · commit ce66098c7139 · 2023-02-09T20:04:30.000+05:30
* fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests. * For details on issue see - #2206
diff --git a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITClosedSessionTest.java b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITClosedSessionTest.java
@@ -251,7 +251,10 @@ public void testTransactionManager() throws InterruptedException {
             break;
           }
         } catch (AbortedException e) {
-          Thread.sleep(e.getRetryDelayInMillis());
+          long retryDelayInMillis = e.getRetryDelayInMillis();
+          if (retryDelayInMillis > 0) {
+            Thread.sleep(retryDelayInMillis);
+          }
           txn = manager.resetForRetry();
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,10 @@ public void testTransactionManager() throws InterruptedException {`
`251`	`251`	`break;`
`252`	`252`	`}`
`253`	`253`	`} catch (AbortedException e) {`
`254`		`- Thread.sleep(e.getRetryDelayInMillis());`
	`254`	`+ long retryDelayInMillis = e.getRetryDelayInMillis();`
	`255`	`+ if (retryDelayInMillis > 0) {`
	`256`	`+ Thread.sleep(retryDelayInMillis);`
	`257`	`+ }`
`255`	`258`	`txn = manager.resetForRetry();`
`256`	`259`	`}`
`257`	`260`	`}`