samples: add event time as a custom attribute #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samples/snippets/src/main/java/pubsublite/PublishWithCustomAttributesExample.java
Outdated
Show resolved
Hide resolved
| System.out.println("Data : " + message.getData().toStringUtf8()); | ||
| System.out.println("Ordering key : " + message.getOrderingKey()); | ||
| System.out.println("Attributes : "); | ||
| message |
Collaborator
There was a problem hiding this comment.
I'd also demonstrate extracting the event time
MessageTransforms. decodeAttributeEventTime(message.getAttributesMap().get(MessageTransforms.PUBSUB_LITE_EVENT_TIME_TIMESTAMP_PROTO))
Contributor
Author
There was a problem hiding this comment.
This is a generic SubscriberExample for messages with and without attributes.
Collaborator
There was a problem hiding this comment.
Ah okay. Thats fine then. Could you add:
if (message.getAttributesMap().containsKey(MessageTransforms.PUBSUB_LITE_EVENT_TIME_TIMESTAMP_PROTO)) {
System.out.println("Event timestamp : ", + MessageTransforms. decodeAttributeEventTime(message.getAttributesMap().get(MessageTransforms.PUBSUB_LITE_EVENT_TIME_TIMESTAMP_PROTO)));
}
Contributor
Author
There was a problem hiding this comment.
Yep, a if..else exists in the last commit.
2a26631 to
b3b55f0
Compare
dpcollins-google
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #856
Show the proper way to publish a message to Pub/Sub Lite with an event time as an attribute.