Skip to content

samples: Add seek subscription sample #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmdiep merged 8 commits into from
Aug 10, 2021
Merged

samples: Add seek subscription sample #771

tmdiep merged 8 commits into from
Aug 10, 2021

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jul 29, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@tmdiep tmdiep added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 29, 2021
@tmdiep tmdiep requested review from a team as code owners July 29, 2021 02:19
@snippet-bot
Copy link

snippet-bot bot commented Jul 29, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jul 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 29, 2021
@generated-files-bot
Copy link

generated-files-bot bot commented Jul 29, 2021

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml

@tmdiep
Copy link
Contributor Author

tmdiep commented Jul 29, 2021

Note: this sample is for a pre-release feature.

anguillanneuf
anguillanneuf requested changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thanh-Mai. Just add more comments about SeekTarget.

@tmdiep
Copy link
Contributor Author

tmdiep commented Jul 29, 2021

Thanks Tianzi. It is indeed clearer with more comments.

@tmdiep tmdiep requested a review from anguillanneuf July 29, 2021 23:39
@tmdiep tmdiep added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2021
@tmdiep tmdiep merged commit d1ee73b into googleapis:master Aug 10, 2021
@tmdiep tmdiep deleted the seek_sample branch August 10, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees

No one assigned

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmdiep @anguillanneuf @dzlier-gcp @yoshi-kokoro