Skip to content

feat: Implement interfaces and utilities needed for Pub/Sub Lite Kafka shim #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpcollins-google merged 6 commits into from
Oct 5, 2020
Merged

feat: Implement interfaces and utilities needed for Pub/Sub Lite Kafka shim #276

dpcollins-google merged 6 commits into from
Oct 5, 2020

Conversation

@dpcollins-google
Copy link
Collaborator

@dpcollins-google dpcollins-google commented Oct 2, 2020

Also run mvn fmt:format

@dpcollins-google dpcollins-google requested a review from a team as a code owner October 2, 2020 20:42
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020 •
edited
Loading

Codecov Report

Merging #276 into master will decrease coverage by 0.81%.
The diff coverage is 36.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #276      +/-   ##
============================================
- Coverage     71.73%   70.91%   -0.82%     
- Complexity      771      780       +9     
============================================
  Files           141      145       +4     
  Lines          4136     4243     +107     
  Branches        215      216       +1     
============================================
+ Hits           2967     3009      +42     
- Misses         1044     1107      +63     
- Partials        125      127       +2
Impacted Files Coverage Δ Complexity Δ
...le/cloud/pubsublite/kafka/KafkaExceptionUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../google/cloud/pubsublite/kafka/PubsubLiteNode.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...oogle/cloud/pubsublite/internal/ExtractStatus.java 44.44% <30.43%> (-33.34%) 4.00 <1.00> (-2.00)
...com/google/cloud/pubsublite/kafka/LiteHeaders.java 34.78% <34.78%> (ø) 4.00 <4.00> (?)
...oogle/cloud/pubsublite/kafka/RecordTransforms.java 84.61% <84.61%> (ø) 3.00 <3.00> (?)
...d/pubsublite/internal/BufferingPullSubscriber.java 85.71% <0.00%> (+3.66%) 8.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf29f8...336d815. Read the comment docs.

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Oct 3, 2020
@dpcollins-google dpcollins-google mentioned this pull request Oct 5, 2020
Merged
@dpcollins-google dpcollins-google merged commit 3c43ef3 into master Oct 5, 2020
@dpcollins-google dpcollins-google deleted the extract-status-changes branch October 5, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelmenzella-google manuelmenzella-google manuelmenzella-google approved these changes

Assignees

No one assigned

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpcollins-google @manuelmenzella-google