Skip to content

chore: generate non-cloud client library (#1770) #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 1 commit into from
Mar 3, 2023
Merged

chore: generate non-cloud client library (#1770) #1349

gcf-merge-on-green merged 1 commit into from
Mar 3, 2023

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 24, 2023

  • chore: add proto group prefix

  • add test case for generating google maps

  • run new tests in ci

  • parameterize group id for proto artifacts

  • use helper to compute group id of proto artifacts

  • verify non cloud library generation

  • change artifact name in golden

  • restore new client test

  • change description

  • change description

  • add comments to _proto_group_id
    Source-Link: googleapis/synthtool@269a915
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:9bf82029163bc06d58f56682afd1893a42ace3e04b0359accb86f79c6ecdc9f9

@gcf-owl-bot
chore: generate non-cloud client library (#1770)
5a33543 
* chore: add proto group prefix

* add test case for generating google maps

* run new tests in ci

* parameterize group id for proto artifacts

* use helper to compute group id of proto artifacts

* verify non cloud library generation

* change artifact name in golden

* restore new client test

* change description

* change description

* add comments to _proto_group_id
Source-Link: googleapis/synthtool@269a915
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:9bf82029163bc06d58f56682afd1893a42ace3e04b0359accb86f79c6ecdc9f9
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners February 24, 2023 21:33
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 24, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 24, 2023
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Feb 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2023
@tmdiep tmdiep added the automerge Merge the pull request once unit tests and other checks pass. label Mar 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit aea3ced into main Mar 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-update-lock-9bf82029163bc06d58f56682afd1893a42ace3e04b0359accb86f79c6ecdc9f9 branch March 3, 2023 23:22
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tmdiep tmdiep tmdiep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. owl-bot-update-lock size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmdiep @yoshi-kokoro