Skip to content

Conversation

@dpcollins-google
Copy link
Collaborator

Also fix a build issue and reformat all java files.

Also fix a build issue and reformat all java files.
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage     59.98%   59.98%           
  Complexity      393      393           
=========================================
  Files            89       89           
  Lines          2044     2044           
  Branches        173      173           
=========================================
  Hits           1226     1226           
  Misses          723      723           
  Partials         95       95           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e6208...f7ff197. Read the comment docs.

@anguillanneuf
Copy link
Contributor

anguillanneuf commented Jun 12, 2020

Nit: use conventional commits.

"feat: ..." with no period at the end.

@dpcollins-google dpcollins-google changed the title [feat] Import and build new Pub/Sub Lite assignment protos. feat: Import and build new Pub/Sub Lite assignment protos Jun 13, 2020
@dpcollins-google dpcollins-google merged commit 2d5242f into master Jun 13, 2020
@dpcollins-google dpcollins-google deleted the assignment-protos branch June 13, 2020 13:12
@dpcollins-google dpcollins-google restored the assignment-protos branch June 15, 2020 19:41
@chingor13 chingor13 deleted the assignment-protos branch April 15, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants