Skip to content

samples: create a Pub/Sub export subscription #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 5 commits into from
Dec 9, 2022
Merged

samples: create a Pub/Sub export subscription #1247

gcf-merge-on-green merged 5 commits into from
Dec 9, 2022

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Oct 13, 2022

Added a sample for creating an export subscription to a Pub/Sub topic and test.

@tmdiep
samples: create a Pub/Sub export subscription
af669bd 
Added a sample for creating an export subscription to a Pub/Sub topic and test.
@snippet-bot
Copy link

snippet-bot bot commented Oct 13, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsublite Issues related to the googleapis/java-pubsublite API. labels Oct 13, 2022
@tmdiep tmdiep requested a review from anguillanneuf October 13, 2022 07:26
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 13, 2022
@tmdiep tmdiep added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 13, 2022
dpcollins-google
dpcollins-google reviewed Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add a sample using the initial seek?

@tmdiep
Copy link
Contributor Author

tmdiep commented Oct 21, 2022

Seek target added to this sample. A new release of the main library is required for sample integration tests to pass.

@tmdiep tmdiep added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2022
@tmdiep tmdiep added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2022
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners December 9, 2022 23:35
@tmdiep tmdiep added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2022
@tmdiep tmdiep added the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit d61446e into googleapis:main Dec 9, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@dpcollins-google dpcollins-google dpcollins-google approved these changes

Assignees

@shubha-rajan shubha-rajan

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmdiep @anguillanneuf @dpcollins-google @shubha-rajan @yoshi-kokoro