Skip to content

Include flogger-system-backend in library pom as a runtime dep #213

@anguillanneuf

Description

@anguillanneuf

If we make flogger-system-backend a runtime dependency in google-cloud-pubsublite/pom.xml, do we still need to specify it for samples? The goal is to clean up dependencies in the samples pom.xml if possible:

<!-- [START pubsublite_install_without_bom] -->
<!-- [START pubsublite_java_dependencies] -->
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsublite</artifactId>
<version>0.2.0</version>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsub</artifactId>
<version>1.108.1</version>
</dependency>
<!-- A logging dependency used by the underlying library -->
<dependency>
<groupId>com.google.flogger</groupId>
<artifactId>flogger-system-backend</artifactId>
<version>0.5.1</version>
<scope>runtime</scope>
</dependency>
<!-- [END pubsublite_java_dependencies] -->
<!-- [END pubsublite_install_without_bom] -->

Cc: @BenWhitehead

Metadata

Metadata

Labels

api: pubsubliteIssues related to the googleapis/java-pubsublite API.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions