-
Notifications
You must be signed in to change notification settings - Fork 24
Closed
Labels
api: pubsubliteIssues related to the googleapis/java-pubsublite API.Issues related to the googleapis/java-pubsublite API.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Description
If we make flogger-system-backend a runtime dependency in google-cloud-pubsublite/pom.xml, do we still need to specify it for samples? The goal is to clean up dependencies in the samples pom.xml if possible:
java-pubsublite/samples/snippets/pom.xml
Lines 44 to 64 in 30a276b
| <!-- [START pubsublite_install_without_bom] --> | |
| <!-- [START pubsublite_java_dependencies] --> | |
| <dependency> | |
| <groupId>com.google.cloud</groupId> | |
| <artifactId>google-cloud-pubsublite</artifactId> | |
| <version>0.2.0</version> | |
| </dependency> | |
| <dependency> | |
| <groupId>com.google.cloud</groupId> | |
| <artifactId>google-cloud-pubsub</artifactId> | |
| <version>1.108.1</version> | |
| </dependency> | |
| <!-- A logging dependency used by the underlying library --> | |
| <dependency> | |
| <groupId>com.google.flogger</groupId> | |
| <artifactId>flogger-system-backend</artifactId> | |
| <version>0.5.1</version> | |
| <scope>runtime</scope> | |
| </dependency> | |
| <!-- [END pubsublite_java_dependencies] --> | |
| <!-- [END pubsublite_install_without_bom] --> |
Cc: @BenWhitehead
Metadata
Metadata
Assignees
Labels
api: pubsubliteIssues related to the googleapis/java-pubsublite API.Issues related to the googleapis/java-pubsublite API.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.