fix: remove deprecated tag that was added prematurely #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isherServiceImpl.java
…e currently outstanding message has finished publishing with an ordering key that the last batch does in fact get published.
…requests for better ordering keys affinity
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
============================================
- Coverage 79.94% 79.90% -0.04%
Complexity 305 305
============================================
Files 21 21
Lines 2603 2603
Branches 129 129
============================================
- Hits 2081 2080 -1
Misses 467 467
- Partials 55 56 +1
Continue to review full report at Codecov.
|
hannahrogers-google
approved these changes
Feb 27, 2020
Contributor
hannahrogers-google
left a comment
There was a problem hiding this comment.
LGTM. Can you just run 'mvn clean verify' before submitting to correct the formatting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58