Skip to content

Conversation

@anguillanneuf
Copy link
Contributor

Add download links to Avro tools and protocol buffers in comments.

Describe how to compile the classes used in the publish samples.

Fix a mistake in one comment.

@anguillanneuf anguillanneuf requested a review from a team February 25, 2021 01:18
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Feb 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #538 (be83b56) into master (aec7b12) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #538   +/-   ##
=========================================
  Coverage     78.79%   78.79%           
  Complexity      376      376           
=========================================
  Files            27       27           
  Lines          3414     3414           
  Branches        171      171           
=========================================
  Hits           2690     2690           
  Misses          651      651           
  Partials         73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec7b12...915080f. Read the comment docs.

@anguillanneuf anguillanneuf requested review from a team as code owners February 25, 2021 01:24
Copy link

@shubha-rajan shubha-rajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anguillanneuf anguillanneuf merged commit 8e4277f into master Feb 25, 2021
@anguillanneuf anguillanneuf deleted the samples-comments branch February 25, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants