Skip to content

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Feb 6, 2024

The "Kokoro - Against Pub/Sub Lite samples" has been failing for a while. Hannah is investigating the failure. In the meantime, let's unblock other pull requests and add it back to the required checks once the underlying the problem is resolved.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

The "Kokoro - Against Pub/Sub Lite samples" has been failing for a while.
@suztomo suztomo requested review from a team as code owners February 6, 2024 21:55
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Feb 6, 2024
@suztomo suztomo requested a review from michaelpri10 February 6, 2024 21:55
@suztomo suztomo changed the title chore: disabling Kokoro - Against Pub/Sub Lite samples chore: removing Kokoro - Against Pub/Sub Lite samples from required checks Feb 6, 2024
@suztomo suztomo merged commit e062179 into main Feb 6, 2024
@suztomo suztomo deleted the suztomo-patch-1 branch February 6, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants