Skip to content

ci: unmanaged dependency check #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelpri10 merged 2 commits into from
Feb 6, 2024
Merged

ci: unmanaged dependency check #1892

michaelpri10 merged 2 commits into from
Feb 6, 2024

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Feb 5, 2024 •
edited
Loading

@michaelpri10 This is is the implementation for the one I got your review in
go/cloud-sdk-java-dependency-governance-design. This check will
avoid accidentally adding a third-party dependency.

b/320677249

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@suztomo
ci: unmanaged dependency check
3227332 
This is is the implementation for the one I got your review in
go/cloud-sdk-java-dependency-governance-design. This check will
avoid accidentally adding a third-party dependency.

b/320677249
@suztomo suztomo requested review from a team as code owners February 5, 2024 17:16
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Feb 5, 2024
@suztomo suztomo marked this pull request as draft February 5, 2024 17:17
@suztomo
Copy link
Member Author

suztomo commented Feb 5, 2024

Unmanaged dependency check / unmanaged_dependency_check (pull_request) Successful

@suztomo
Copy link
Member Author

suztomo commented Feb 5, 2024

"Kokoro - Against Pub/Sub Lite samples" has been red for a while. Irrelevant to this CI.

@suztomo suztomo marked this pull request as ready for review February 5, 2024 18:03
@michaelpri10 michaelpri10 merged commit 6d6dc89 into main Feb 6, 2024
@michaelpri10 michaelpri10 deleted the unmanaged_dependency_check branch February 6, 2024 23:27
@suztomo suztomo mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelpri10 michaelpri10 michaelpri10 approved these changes

Assignees

@michaelpri10 michaelpri10

@maitrimangal maitrimangal

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suztomo @michaelpri10 @maitrimangal