Skip to content

Conversation

@renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Update Change
com.google.cloud.samples:shared-configuration patch 1.0.15 -> 1.0.17
com.google.cloud.samples:shared-configuration patch 1.0.12 -> 1.0.17

Release Notes

GoogleCloudPlatform/java-repo-tools

v1.0.17

Compare Source

  • require -P lint
    Lets not burden customers with our development rules.
    • Move Checkstyle, ErrorProne, PMD, and SpotBugs to only run w/ -P lint
    • Update the Readme
  • spotbugs-annotations 4.0.2

v1.0.16

Compare Source

Add a few SpotBugs exclusions:

  • RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE - existing - codegen bug
  • UPM_UNCALLED_PRIVATE_METHOD - probably SpotBug issue
  • NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE - likely SpotBug issue
  • CLI_CONSTANT_LIST_INDEX - style issue particular to our samples
  • OBL_UNSATISFIED_OBLIGATION - issue for SQL clients

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 5, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 5, 2020
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #178 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
- Coverage     78.41%   78.37%   -0.04%     
  Complexity      302      302              
============================================
  Files            21       21              
  Lines          2719     2719              
  Branches        134      134              
============================================
- Hits           2132     2131       -1     
  Misses          513      513              
- Partials         74       75       +1     
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 85.14% <0.00%> (-0.50%) 25.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486ed41...1675c49. Read the comment docs.

@hannahrogers-google hannahrogers-google merged commit e4e350d into googleapis:master May 7, 2020
@renovate-bot renovate-bot deleted the renovate/com.google.cloud.samples-shared-configuration-1.x branch May 7, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants