Skip to content

docs(sample): remove protobuf feature from native image sample #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mpeddada1 wants to merge 3 commits into from
Closed

docs(sample): remove protobuf feature from native image sample #1077

mpeddada1 wants to merge 3 commits into from

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Mar 31, 2022

The ProtobufMessageFeature will automatically be brought in after googleapis/gax-java#1641 is merged and released. Merge after PR 1641 is released.

@mpeddada1 mpeddada1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 31, 2022
@mpeddada1 mpeddada1 requested review from a team as code owners March 31, 2022 20:53
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Mar 31, 2022
@mpeddada1 mpeddada1 mentioned this pull request Mar 31, 2022
Merged
@meltsufin meltsufin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 20, 2022
@product-auto-label product-auto-label bot added the size: u Pull request is empty. label May 20, 2022
@meltsufin meltsufin closed this May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meltsufin meltsufin meltsufin approved these changes

+1 more reviewer

@averikitsch averikitsch averikitsch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: u Pull request is empty.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpeddada1 @averikitsch @meltsufin