Skip to content

samples: create subscription with exactly once delivery enabled #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anguillanneuf merged 3 commits into from
Mar 4, 2022
Merged

samples: create subscription with exactly once delivery enabled #1032

anguillanneuf merged 3 commits into from
Mar 4, 2022

Conversation

@anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Feb 28, 2022 •
edited
Loading

Towards b/221105785

To be merged after #1022 and a new release.

@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Feb 28, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 28, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@anguillanneuf anguillanneuf marked this pull request as ready for review February 28, 2022 22:59
@anguillanneuf anguillanneuf requested review from a team as code owners February 28, 2022 22:59
mmicatka
mmicatka approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@mmicatka mmicatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anguillanneuf anguillanneuf merged commit 7e08361 into main Mar 4, 2022
@anguillanneuf anguillanneuf deleted the exactly_once branch March 4, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maheshgattani maheshgattani maheshgattani approved these changes

+1 more reviewer

@mmicatka mmicatka mmicatka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anguillanneuf @maheshgattani @mmicatka