samples: add samples for new KMS rng APIs#577
samples: add samples for new KMS rng APIs#577gcf-merge-on-green[bot] merged 1 commit intogoogleapis:masterfrom sethvargo:sethvargo/kms_rng
Conversation
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
chingor13
left a comment
There was a problem hiding this comment.
Thanks! LGTM
Going to rename this to merge as samples: as feat: will bump the client library version.
|
|
||
| // Generate the bytes. | ||
| GenerateRandomBytesResponse response = | ||
| client.generateRandomBytes(locationName.toString(), numBytes, ProtectionLevel.HSM); |
There was a problem hiding this comment.
Side note: the fact that we have to call toString() on the resource name instance implies that we're missing a resource name annotation on this API. It should have an overload that accepts the LocationName instance directly.
There was a problem hiding this comment.
I felt the same way, but confirmed there was no overload. I would be supportive of adding that. What's the process for doing so?
This adds samples for the new RNG APIs.